-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURESIGN-1659] Add AAP testing scenario for collection #119
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,53 @@ | |||
name: Using Ansible Molecule, test RHTAS collection from a private AAP | |||
|
|||
# on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be uncommented once the PR is reviewed and build log is verified.
LGTM we can monitor it over the coming weeks to see if everything is up to scratch! |
Thanks for the PR Firas! It looks in really solid shape @bkabrda I believe we could symlink a bunch of the unchanged files, or put some of the generic tasks like standing up the AWS infra into their own yml files and just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, just left a comment for Slavek to take a look at that might make sense for this PR
Thanks Firas!
- vars/vars.yml | ||
- vars/aap_nodes.yml | ||
tasks: | ||
- name: Error out if registry username is not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use check_creds.yml
here too for these two tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SequeI , I don't think we can use it, the when condition is based on different variable here: aap_setup_prep_inv_secrets.all.registry_username
- vars/vars.yml | ||
- vars/podman.yml | ||
tasks: | ||
- name: Error out if registry username is not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have an include_tasks
here and use the check_creds.yml tasks
@@ -0,0 +1,12 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be necessary as we're not using TF anymore.
Ready to be reviewed