Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-1659] Add AAP testing scenario for collection #119

Open
wants to merge 98 commits into
base: main
Choose a base branch
from

Conversation

fghanmi
Copy link
Collaborator

@fghanmi fghanmi commented Dec 23, 2024

Ready to be reviewed

@fghanmi fghanmi requested a review from a team as a code owner December 23, 2024 10:51
@fghanmi fghanmi changed the title [on-going] add aap ci test [In progress] add aap ci test Dec 23, 2024
@fghanmi fghanmi removed the request for review from a team December 23, 2024 15:06
@fghanmi fghanmi changed the title [In progress] add aap ci test Add AAP testing scenario for collection Dec 31, 2024
@fghanmi fghanmi changed the title Add AAP testing scenario for collection [SECURESIGN-1659] Add AAP testing scenario for collection Dec 31, 2024
@fghanmi fghanmi requested a review from a team January 2, 2025 13:18
@@ -0,0 +1,53 @@
name: Using Ansible Molecule, test RHTAS collection from a private AAP

# on:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be uncommented once the PR is reviewed and build log is verified.

@tommyd450
Copy link
Collaborator

LGTM we can monitor it over the coming weeks to see if everything is up to scratch!

@SequeI
Copy link
Collaborator

SequeI commented Jan 7, 2025

Thanks for the PR Firas! It looks in really solid shape

@bkabrda I believe we could symlink a bunch of the unchanged files, or put some of the generic tasks like standing up the AWS infra into their own yml files and just include_tasks them to reduce code duplicity, WDYT? Although not sure if this is a big deal since this is just for testing.

Copy link
Collaborator

@SequeI SequeI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, just left a comment for Slavek to take a look at that might make sense for this PR

Thanks Firas!

- vars/vars.yml
- vars/aap_nodes.yml
tasks:
- name: Error out if registry username is not set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use check_creds.yml here too for these two tasks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SequeI , I don't think we can use it, the when condition is based on different variable here: aap_setup_prep_inv_secrets.all.registry_username

- vars/vars.yml
- vars/podman.yml
tasks:
- name: Error out if registry username is not set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have an include_tasks here and use the check_creds.yml tasks

@@ -0,0 +1,12 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be necessary as we're not using TF anymore.

@bkabrda
Copy link
Collaborator

bkabrda commented Jan 13, 2025

I definitely agree with @SequeI that we should reuse as much code as possible here by symlinking and/or reusing Ansible task files. Can you do that before I do a full review @fghanmi? Thanks!

@fghanmi fghanmi requested a review from bkabrda January 14, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants